From 1a9e301966c35317df639f277fb47616fddcc8f2 Mon Sep 17 00:00:00 2001
From: "jvanboxtel@wisc.edu" <jvanboxtel@wisc.edu>
Date: Tue, 26 Mar 2019 15:01:39 -0500
Subject: [PATCH] ROENROLL-1482 disappearing SFL courses
---
.../sidenav-menu-item/sidenav-menu-item.component.html | 2 +-
.../sidenav-menu-item/sidenav-menu-item.component.scss | 2 --
src/app/degree-planner/store/effects/course.effects.ts | 2 +-
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/app/degree-planner/sidenav-menu-item/sidenav-menu-item.component.html b/src/app/degree-planner/sidenav-menu-item/sidenav-menu-item.component.html
index 4bc00cc..b3f883a 100644
--- a/src/app/degree-planner/sidenav-menu-item/sidenav-menu-item.component.html
+++ b/src/app/degree-planner/sidenav-menu-item/sidenav-menu-item.component.html
@@ -45,7 +45,7 @@
alt="Course no loger offered icon"
matTooltip="Course no loger offered"
matTooltipPosition="left">remove</i>
- Course no loger offered
+ Course no longer offered
</mat-list-item>
</mat-list>
</mat-expansion-panel>
diff --git a/src/app/degree-planner/sidenav-menu-item/sidenav-menu-item.component.scss b/src/app/degree-planner/sidenav-menu-item/sidenav-menu-item.component.scss
index 7446d05..aa6e2b6 100644
--- a/src/app/degree-planner/sidenav-menu-item/sidenav-menu-item.component.scss
+++ b/src/app/degree-planner/sidenav-menu-item/sidenav-menu-item.component.scss
@@ -2,10 +2,8 @@
@import 'assets/material-theme.scss';
#sidenav-container {
- height: 100vh;
.mat-expansion-panel {
border-radius: 0px;
- // overflow: visible;
}
h3 {
font-weight: 400;
diff --git a/src/app/degree-planner/store/effects/course.effects.ts b/src/app/degree-planner/store/effects/course.effects.ts
index 06d1206..25552d5 100644
--- a/src/app/degree-planner/store/effects/course.effects.ts
+++ b/src/app/degree-planner/store/effects/course.effects.ts
@@ -131,7 +131,7 @@ export class CourseEffects {
const { subjectCode, termCode, courseId, newIndex } = action.payload;
let addCourse$: Observable<CourseBase>;
- const isActiveTerm = activeTerms.filter(term => term.equals(termCode));
+ const isActiveTerm = activeTerms.some(term => term.equals(termCode));
const isPrimaryPlan = visibleDegreePlan
? visibleDegreePlan.primary
: false;
--
GitLab