From f1a1daba11f67963d195f0a0728fbc94cbe5aa6c Mon Sep 17 00:00:00 2001
From: pnogal <paulina.nogal@wisc.edu>
Date: Mon, 26 Nov 2018 14:28:34 -0600
Subject: [PATCH] remove values-to-string.pipe
---
.../course-details-dialog.component.html | 4 ++--
.../course-details-dialog.component.ts | 4 ++++
src/app/shared/shared.module.ts | 5 ++---
src/app/shared/values-to-string.pipe.ts | 12 ------------
4 files changed, 8 insertions(+), 17 deletions(-)
delete mode 100644 src/app/shared/values-to-string.pipe.ts
diff --git a/src/app/degree-planner/dialogs/course-details-dialog/course-details-dialog.component.html b/src/app/degree-planner/dialogs/course-details-dialog/course-details-dialog.component.html
index 5974c36..28e5d6b 100644
--- a/src/app/degree-planner/dialogs/course-details-dialog/course-details-dialog.component.html
+++ b/src/app/degree-planner/dialogs/course-details-dialog/course-details-dialog.component.html
@@ -26,10 +26,10 @@
<ul>
<li *ngIf="courseDetails.creditRange"><span class="semi-bold">Credits:</span> {{ courseDetails.creditRange }}</li>
<li *ngIf="courseDetails.levels && courseDetails.levels.length > 0"><span class="semi-bold">Level:</span>
- {{ courseDetails.levels | valuesToString:'description' }}
+ {{ mapDescriptions(courseDetails.levels) }}
</li>
<li *ngIf="courseDetails.breadths && courseDetails.breadths.length > 0"><span class="semi-bold">Breadth:</span>
- {{ courseDetails.breadths | valuesToString:'description' }}
+ {{ mapDescriptions(courseDetails.breadths) }}
</li>
<li *ngIf="courseDetails.lettersAndScienceCredits"><span class="semi-bold">L&S Credit Type:</span>
{{ courseDetails.lettersAndScienceCredits.description }}
diff --git a/src/app/degree-planner/dialogs/course-details-dialog/course-details-dialog.component.ts b/src/app/degree-planner/dialogs/course-details-dialog/course-details-dialog.component.ts
index 59aff05..0347ea6 100644
--- a/src/app/degree-planner/dialogs/course-details-dialog/course-details-dialog.component.ts
+++ b/src/app/degree-planner/dialogs/course-details-dialog/course-details-dialog.component.ts
@@ -16,6 +16,10 @@ export class CourseDetailsDialogComponent implements OnInit {
this.courseDetails = data.courseDetails;
}
+ mapDescriptions(objects) {
+ return objects.map(object => object.description);
+ }
+
ngOnInit() {
}
}
diff --git a/src/app/shared/shared.module.ts b/src/app/shared/shared.module.ts
index 17fe161..f8fba8e 100644
--- a/src/app/shared/shared.module.ts
+++ b/src/app/shared/shared.module.ts
@@ -16,7 +16,6 @@ import { MatDialogModule } from '@angular/material/dialog';
import { GetTermDescriptionPipe } from './get-term-description.pipe';
import { AcademicYearStatePipe } from './academic-year-state.pipe';
-import { ValuesToStringPipe } from './values-to-string.pipe';
const modules = [
CommonModule,
@@ -37,8 +36,8 @@ const modules = [
@NgModule({
imports: [ modules ],
- exports: [ modules, GetTermDescriptionPipe, AcademicYearStatePipe, ValuesToStringPipe ],
- declarations: [ GetTermDescriptionPipe, AcademicYearStatePipe, ValuesToStringPipe ]
+ exports: [ modules, GetTermDescriptionPipe, AcademicYearStatePipe ],
+ declarations: [ GetTermDescriptionPipe, AcademicYearStatePipe ]
})
export class SharedModule { }
diff --git a/src/app/shared/values-to-string.pipe.ts b/src/app/shared/values-to-string.pipe.ts
deleted file mode 100644
index 9615a89..0000000
--- a/src/app/shared/values-to-string.pipe.ts
+++ /dev/null
@@ -1,12 +0,0 @@
-import { Pipe, PipeTransform } from '@angular/core';
-
-@Pipe({
- name: 'valuesToString'
-})
-
-export class ValuesToStringPipe implements PipeTransform {
-
- transform(array: [], key: any): any {
- return array.map(element => element[key]).join(', ');
- }
-}
--
GitLab