From 9e7d2b79b48d5767a3a33715455c44ab84846a51 Mon Sep 17 00:00:00 2001
From: Andy Summers <andrew.summers@wisc.edu>
Date: Mon, 14 Aug 2017 13:19:07 -0500
Subject: [PATCH] Add PHP7 type annotations to Interfacing classes
---
.../cbs/order/interfacing/MockOrderInterfacingService.php | 2 +-
.../cbs/order/interfacing/OrderInterfacingService.php | 4 ++--
.../cbs/order/interfacing/SoapOrderInterfacingService.php | 5 ++++-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/main/edu/wisc/services/cbs/order/interfacing/MockOrderInterfacingService.php b/src/main/edu/wisc/services/cbs/order/interfacing/MockOrderInterfacingService.php
index 017ae86..7235018 100644
--- a/src/main/edu/wisc/services/cbs/order/interfacing/MockOrderInterfacingService.php
+++ b/src/main/edu/wisc/services/cbs/order/interfacing/MockOrderInterfacingService.php
@@ -30,7 +30,7 @@ class MockOrderInterfacingService implements OrderInterfacingService, MockServic
/**
* {@inheritdoc}
*/
- public function interfaceOrder($orderNumber)
+ public function interfaceOrder($orderNumber): OrderServiceResponse
{
return $this->response;
}
diff --git a/src/main/edu/wisc/services/cbs/order/interfacing/OrderInterfacingService.php b/src/main/edu/wisc/services/cbs/order/interfacing/OrderInterfacingService.php
index da2fd00..fd65296 100644
--- a/src/main/edu/wisc/services/cbs/order/interfacing/OrderInterfacingService.php
+++ b/src/main/edu/wisc/services/cbs/order/interfacing/OrderInterfacingService.php
@@ -13,9 +13,9 @@ interface OrderInterfacingService extends Service
/**
* Commit and finalize ("interface") an order with CBS.
- * @param string $orderNumber
+ * @param float $orderNumber
* @return OrderServiceResponse
*/
- public function interfaceOrder($orderNumber);
+ public function interfaceOrder($orderNumber): OrderServiceResponse;
}
\ No newline at end of file
diff --git a/src/main/edu/wisc/services/cbs/order/interfacing/SoapOrderInterfacingService.php b/src/main/edu/wisc/services/cbs/order/interfacing/SoapOrderInterfacingService.php
index 27a070a..300e399 100644
--- a/src/main/edu/wisc/services/cbs/order/interfacing/SoapOrderInterfacingService.php
+++ b/src/main/edu/wisc/services/cbs/order/interfacing/SoapOrderInterfacingService.php
@@ -45,7 +45,10 @@ class SoapOrderInterfacingService implements OrderInterfacingService, SoapServic
}
}
- public function interfaceOrder($orderNumber)
+ /**
+ * {@inheritdoc}
+ */
+ public function interfaceOrder($orderNumber): OrderServiceResponse
{
$response = $this->soapClient->INTERFACE_ORDER(
new InputParameters($orderNumber, "MAGE$orderNumber", 'TBD')
--
GitLab