diff --git a/src/main/edu/wisc/doit/FederatedPreauthUserDetailsProvider.php b/src/main/edu/wisc/doit/FederatedPreauthUserDetailsProvider.php index f2ed252a26ffae3d74da545b25bbe2080f66e13c..94ea4103c21605fe9d289b10e01d41e699e405b9 100644 --- a/src/main/edu/wisc/doit/FederatedPreauthUserDetailsProvider.php +++ b/src/main/edu/wisc/doit/FederatedPreauthUserDetailsProvider.php @@ -9,9 +9,6 @@ namespace edu\wisc\doit; class FederatedPreauthUserDetailsProvider implements UserDetailsProvider { - const SHIB_SESSION_ID = 'Shib-Session-Id'; - const SHIB_SESSION_ID_HTTP = 'HTTP_SHIB_SESSION_ID'; - /** @var bool */ private $httpHeaders; diff --git a/src/main/edu/wisc/doit/UserDetailsProvider.php b/src/main/edu/wisc/doit/UserDetailsProvider.php index 0b6381b0577d3bcc68f62e34b0c6ae94e414b64a..36c7244322e5f9bd910792efd35b2b897f308b06 100644 --- a/src/main/edu/wisc/doit/UserDetailsProvider.php +++ b/src/main/edu/wisc/doit/UserDetailsProvider.php @@ -8,13 +8,17 @@ namespace edu\wisc\doit; interface UserDetailsProvider { - // Constants representing UW Federated login Shibboleth headers which should be mapped by concrete implementations. + // Constants representing UW Federated login Shibboleth headers const FED_EPPN = "eppn"; const FED_SPVI = "eduWisconsinSPVI"; const FED_FULLNAME = "eduWisconsinCommonName"; const FED_FIRST_NAME = "eduWisconsinGivenName"; const FED_LAST_NAME = "eduWisconsinSurname"; const FED_EMAIL = "eduWisconsinEmailAddress"; + + // Generic and/or UWMSN constants + const SHIB_SESSION_ID = 'Shib-Session-Id'; + const SHIB_SESSION_ID_HTTP = 'HTTP_SHIB_SESSION_ID'; const UDDS = "udds"; const SOURCE = "source"; const ISIS_EMPLID = "isisEmplid"; diff --git a/src/test/edu/wisc/doit/FederatedPreauthUserDetailsProviderTest.php b/src/test/edu/wisc/doit/FederatedPreauthUserDetailsProviderTest.php index d28bf7b2e26cd3278b223472f2443e0d3b8f51a7..cfc0afd72022adc6ca09436828bfffa5b85f007d 100644 --- a/src/test/edu/wisc/doit/FederatedPreauthUserDetailsProviderTest.php +++ b/src/test/edu/wisc/doit/FederatedPreauthUserDetailsProviderTest.php @@ -32,7 +32,7 @@ class FederatedPreauthUserDetailsProviderTest extends \PHPUnit_Framework_TestCas putenv(UserDetailsProvider::FED_EMAIL . '=' . $attributes[UserDetailsProvider::FED_EMAIL]); putenv(UserDetailsProvider::SOURCE . '=' . $attributes[UserDetailsProvider::SOURCE]); putenv(UserDetailsProvider::ISIS_EMPLID . '=' . $attributes[UserDetailsProvider::ISIS_EMPLID]); - putenv(FederatedPreauthUserDetailsProvider::SHIB_SESSION_ID . '=' . $attributes[FederatedPreauthUserDetailsProvider::SHIB_SESSION_ID]); + putenv(UserDetailsProvider::SHIB_SESSION_ID . '=' . $attributes[UserDetailsProvider::SHIB_SESSION_ID]); } public function testLoadUser() { @@ -52,7 +52,7 @@ class FederatedPreauthUserDetailsProviderTest extends \PHPUnit_Framework_TestCas public function testLoadUserWithNoEPPN() { $this->userProvider = new FederatedPreauthUserDetailsProvider(); // Clear Shib session ID to simulate no session - putenv(FederatedPreauthUserDetailsProvider::SHIB_SESSION_ID); + putenv(UserDetailsProvider::SHIB_SESSION_ID); $user = $this->userProvider->loadUser(); $this->assertNull($user); }