From 6d90ded70549829d0ebec541249be3ee319b0de4 Mon Sep 17 00:00:00 2001
From: ashwinmaran <amaran@wisc.edu>
Date: Wed, 22 Mar 2023 16:36:14 -0500
Subject: [PATCH] rubric update

---
 p8/README.md | 1 +
 p8/rubric.md | 9 ++++++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/p8/README.md b/p8/README.md
index e38637a..d646a15 100644
--- a/p8/README.md
+++ b/p8/README.md
@@ -4,6 +4,7 @@
 ## Corrections and clarifications:
 
 * **3/22/2023 - 2:00 PM**: In the `Project Requirements` section, it is stated that `small_movies` is a required data structure. This is a **typo**. It is supposed to be `small_movies_data`.
+* **3/22/2023 - 4:30 PM**: Typos in `rubric.md` fixed. Some rubric items clarified further.
 
 **Find any issues?** Report to us:
 
diff --git a/p8/rubric.md b/p8/rubric.md
index 0f3894e..6382618 100644
--- a/p8/rubric.md
+++ b/p8/rubric.md
@@ -19,6 +19,7 @@
 
 - `get_mapping` (3)
 	- Incorrect logic is used in function (-2)
+	- Function defined more than once (-1)
 
 - Q1 (3)
 	- Required function is not used to answer (-2)
@@ -38,8 +39,9 @@
 	- Answer does not exclude movie titles (-1)
 
 - `get_raw_movies` (5)
-	- Incorrect logic is used in function (-2)
+	- Incorrect logic is used in function (-3)
 	- Column indices are hardcoded instead of using the header to identify column names (-1)
+	- Function defined more than once (-1)
 
 - Q5 (3)
 	- Required function is not used to answer (-2)
@@ -53,7 +55,7 @@
 	- Required data structure is not used (-1)
 	- Answer uses loops to iterate over dictionary keys (-1)
 
-- `get_movies` (7)
+- `get_movies` (8)
 	- Function is called more than once with the same dataset (-4)
 	- Incorrect logic is used in function (-2)
 	- Function loops through IDs in the `mapping_path` file (-2)
@@ -105,7 +107,8 @@
 
 - `genre_dict` (5)
 	- Data structure is defined incorrectly (-3)
-	- Data structure is modified (-2)
+	- Required function is not used (-1)
+	- Data structure is modified (-1)
 
 - Q16 (3)
 	- Required data structure is not used (-2)
-- 
GitLab