diff --git a/p10/rubric.md b/p10/rubric.md index a202fb553124b684042de42dce386f4cebe65c12..d665df33a7c2c87904506f4b5f0c60d1a4278fd4 100644 --- a/p10/rubric.md +++ b/p10/rubric.md @@ -40,13 +40,13 @@ - Paths are hardcoded using "/" or "\\" (-1) - `Star` (2) - - Data structure is defined more than once (-1) - Data structure is defined incorrectly (-1) + - Data structure is defined more than once (-1) - `star_cell` (4) + - Function logic is incorrect (-1) - Column indices are hardcoded (-1) - Function does not typecast based on column names (-1) - - Function logic is incorrect (-1) - Function is defined more than once (-1) - Q5 (4) @@ -54,9 +54,9 @@ - Unnecessarily iterating over the entire dataset (-1) - `get_stars` (6) + - Function logic is incorrect (-2) - Required function is not used (-1) - Hardcoding the name of directory inside the function (-1) - - Function logic is incorrect (-2) - Function is called more than twice with the same dataset (-1) - Function is defined more than once (-1) @@ -72,9 +72,9 @@ - Incorrect logic is used to answer (-1) - `stars_dict` (3) + - Data structure is defined incorrectly (-1) - Required function is not used (-1) - Required data structure is not used (-1) - - Data structure is defined incorrectly (-1) - Q9 (2) - Required data structure is not used (-2) @@ -89,14 +89,14 @@ - Incorrect logic is used to answer (-1) - `Planet` (2) - - Data structure is defined more than once (-1) - Data structure is defined incorrectly (-1) + - Data structure is defined more than once (-1) - `planet_cell` (5) + - Function logic is incorrect (-1) - Column indices are hardcoded (-1) - Function does not typecast based on column names (-1) - Booleans are not typecasted correctly (-1) - - Function logic is incorrect (-1) - Function is defined more than once (-1) - Q12 (4) @@ -105,11 +105,13 @@ - Unnecessarily iterating over the entire dataset (-1) - `get_planets` (8) + - Function logic is incorrect (-2) - Required function is not used (-1) + - Broken CSV rows are hardcoded (-1) + - Broken JSON files are hardcoded (-1) - Hardcoding the name of directory inside the function (-1) - - Function logic is incorrect (-2) - Function is called more than twice with the same dataset (-1) - - Function is defined more than once (-3) + - Function is defined more than once (-1) - Q13 (3) - Required function is not used (-1) @@ -125,9 +127,9 @@ - Paths are hardcoded using "/" or "\\" (-1) - `planets_list` (4) + - Data structure is defined incorrectly (-2) - Required function is not used (-1) - Paths are hardcoded using "/" or "\\" (-1) - - Data structure is defined incorrectly (-2) - Q16 (2) - Required data structure is not used (-2)