Skip to content
Snippets Groups Projects

Fix bugs in CBS service responses

Merged Andy Summers requested to merge andrew-summers/cbs-techstore-client-php:bugfixes into master

SoapOrderHeaderService and SoapOrderLineService had 'typos' in the constructors of the service response. The comparison for the return value of strcasecmp was inside the function call, not after it, so PHP got all confused and was returning the length of the strings rather than a boolean value.

composer.json has already been incremented a patch version for a new release.

Please review: @ahoffmann @weizhong-wang @lloyd-carter @KJOYNER

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading