Clean up and organize in separate packages
I found this project very confusing, so as I read through it, I made changes that I think make it easier to understand.
- Exotic looking generated classes!
- I moved these to
wsdl-generated-classesso that they are not mixed in with our code (as it is,classGenerator.phpwould delete our code too, right?) - When I ran
classGenerator.php, the class names ended in "Custom"; is this normal?
- Interface, facade, and implementation are all in the same package - hard to tell what's what
- Put the service interface and domain object in an
apipackage, and the client, in aclientpackage.
- Unit test for a mock class
- Deleted and made canary tests for real classes (currently no logic to test anyway)
- Renamed integration test as "IT" to match naming convention in phpunit config
- Removed unused mockery dependency
Please review: @ahoffmann @weizhong-wang @alundholm @SDUNAGAN
