Skip to content
Snippets Groups Projects

Update DOIT_SOA_ORDER_IFACE_L to v3

Merged Update DOIT_SOA_ORDER_IFACE_L to v3
andrew-summers/cbs-techstore-client-php:iface-l-v3 into master
1 unresolved thread
Merged Andy Summers requested to merge andrew-summers/cbs-techstore-client-php:iface-l-v3 into master
1 unresolved thread

This PR updates the Order Line WSDL to v3. v3 of DOIT_SOA_ORDER_IFACE_L includes two new parameters, P_UNIT_PROMO_PRICE and P_PROMO_DISCOUNT_NAME for specifying promotional discounts.

Project version bumped to 7.0.0, and some Composer dependencies updated. Being in a refactoring mood, I also changed the datatypes in the OrderLineInputParametersMapper to properly reflect the datatype that InputParameters expects (which is really just a cosmetic change since we immediately set the correct values, but this is 'more correct' either way). I plan on doing the same for the rest of the classes and PHP7-ifying the project for its better type hinting, etc.

Please review: @ahoffmann @weizhong-wang @lloyd-carter @KJOYNER

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andrew Hoffmann
  • Andrew Hoffmann
    Andrew Hoffmann @ahoffmann started a thread on the diff
    • src/main/resources/doit_soa_order_iface_l_v3.xml 0 → 100644
    1 <?xml version = '1.0' encoding = 'UTF-8'?><definitions name="DOIT_SOA_ORDER_IFACE_L_V3" targetNamespace="http://xmlns.oracle.com/apps/ont/soaprovider/plsql/doit_soa_order_iface_l_v3/" xmlns:tns="http://xmlns.oracle.com/apps/ont/soaprovider/plsql/doit_soa_order_iface_l_v3/" xmlns="http://schemas.xmlsoap.org/wsdl/" xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:tns1="http://xmlns.oracle.com/apps/ont/soaprovider/plsql/doit_soa_order_iface_l_v3/line_create/"> <types> <schema xmlns="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" targetNamespace="http://xmlns.oracle.com/apps/ont/soaprovider/plsql/doit_soa_order_iface_l_v3/line_create/"> <include schemaLocation="http://pegasus.doit.wisc.edu:8016/webservices/SOAProvider/plsql/doit_soa_order_iface_l_v3/APPS_DOIT_SOA_ORDER_IFACE_L_V3_LINE_CREATE.xsd"/> </schema> <schema xmlns="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" targetNamespace="http://xmlns.oracle.com/apps/ont/soaprovider/plsql/doit_soa_order_iface_l_v3/"> <element name="SOAHeader"> <complexType> <sequence> <element name="Responsibility" minOccurs="0" type="string"/> <element name="RespApplication" minOccurs="0" type="string"/> <element name="SecurityGroup" minOccurs="0" type="string"/> <element name="NLSLanguage" minOccurs="0" type="string"/> <element name="Org_Id" minOccurs="0" type="string"/> </sequence> </complexType> </element> </schema> </types> <message name="LINE_CREATE_Input_Msg"> <part name="header" element="tns:SOAHeader"/> <part name="body" element="tns1:InputParameters"/> </message> <message name="LINE_CREATE_Output_Msg"> <part name="body" element="tns1:OutputParameters"/> </message> <portType name="DOIT_SOA_ORDER_IFACE_L_V3_PortType"> <operation name="LINE_CREATE"> <input message="tns:LINE_CREATE_Input_Msg"/> <output message="tns:LINE_CREATE_Output_Msg"/> </operation> </portType> <binding name="DOIT_SOA_ORDER_IFACE_L_V3_Binding" type="tns:DOIT_SOA_ORDER_IFACE_L_V3_PortType"> <soap:binding style="document" transport="http://schemas.xmlsoap.org/soap/http"/> <operation name="LINE_CREATE"> <soap:operation soapAction="http://pegasus.doit.wisc.edu:8016/webservices/SOAProvider/plsql/doit_soa_order_iface_l_v3/"/> <input> <soap:header message="tns:LINE_CREATE_Input_Msg" part="header" use="literal"/> <soap:body parts="body" use="literal"/> </input> <output> <soap:body use="literal"/> </output> </operation> </binding> <service name="DOIT_SOA_ORDER_IFACE_L_V3_Service"> <port name="DOIT_SOA_ORDER_IFACE_L_V3_Port" binding="tns:DOIT_SOA_ORDER_IFACE_L_V3_Binding"> <soap:address location="http://pegasus.doit.wisc.edu:8016/webservices/SOAProvider/plsql/doit_soa_order_iface_l_v3/"/> </port> </service></definitions>
  • Andrew Hoffmann
    Andrew Hoffmann @ahoffmann ·
    Contributor

    Other than my couple nitpicky things, this looks great! Nice job :thumbsup:

  • Andy Summers
    Andy Summers @andrew-summers ·
    Author Contributor

    Jenkins build failed due to Composer dependencies. Have any idea about that?

  • Andrew Hoffmann
    Andrew Hoffmann @ahoffmann ·
    Contributor

    @andrew-summers It looks like one of PHPUnit's downstream dependencies requires PHP 7.0+. We should update PHP on Jenkins.

  • Andy Summers added 1 commit

    added 1 commit

    • c2bc76ad - Fix out of order constructor parameters

    Compare with previous version

  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build triggered.

  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build Started: https://ia-builds.doit.wisc.edu:8443/job/cbs-techstore-client-php-master-pull-requests/99/

  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build finished. Tests FAILED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/cbs-techstore-client-php-master-pull-requests/99/

  • Andy Summers
    Andy Summers @andrew-summers ·
    Author Contributor

    Updated the PR, adding the new fields to the integration test and fixing the out of order parameters.

  • Andy Summers
    Andy Summers @andrew-summers ·
    Author Contributor

    build me

  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build triggered.

  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build Started: https://ia-builds.doit.wisc.edu:8443/job/cbs-techstore-client-php-master-pull-requests/100/

  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build finished. Tests PASSED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/cbs-techstore-client-php-master-pull-requests/100/

  • Andy Summers merged

    merged

  • Andy Summers mentioned in commit 483cac13

    mentioned in commit 483cac13

    • Please register or sign in to reply