PHP7-ify the Order Line classes (!72) · Merge requests · adi-ia / cbs-techstore-client-php · GitLab

Snippets Groups Projects

Merged Andy Summers requested to merge andrew-summers/cbs-techstore-client-php:php7 into master 7 years ago

This PR gets the Order Line classes written in PHP7 style for better type hinting, error checking, etc. I'll be going through the rest of the classes doing the same, but doing separate PRs for each so that there aren't 20+ changed files.

Please review: @ahoffmann @weizhong-wang @lloyd-carter @KJOYNER

Activity

ADI-IA Jenkins @adi-ia-jenkins · 7 years ago

Maintainer

Build triggered.
ADI-IA Jenkins @adi-ia-jenkins · 7 years ago

Maintainer

Build Started: https://ia-builds.doit.wisc.edu:8443/job/cbs-techstore-client-php-master-pull-requests/101/
ADI-IA Jenkins @adi-ia-jenkins · 7 years ago

Maintainer

Build finished. Tests PASSED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/cbs-techstore-client-php-master-pull-requests/101/
Andrew Hoffmann @ahoffmann · 7 years ago

Contributor

Nice work!
Andy Summers merged 7 years ago

merged
Andy Summers mentioned in commit fb87815e 7 years ago

mentioned in commit fb87815e

Please register or sign in to reply