Skip to content
Snippets Groups Projects

feat: always populate MANIFEST with project.name and .version

This pull request directs the plugin to configure the jar task (if present, provided by the java plugin) and/or the war task (if present, provided by the war plugin) to set the Implementation-Version and Implementation-Title attributes in the MANIFEST.MF file included in the result.

The end result is that issue #1 (closed) can be satisfied by pulling out Implementation-Version from the MANIFEST. By using MANIFEST, we use a file in Java specifications and we don't have to pollute the build of downstream projects with our own custom properties file.

Manifest reference:

https://docs.oracle.com/javase/tutorial/deployment/jar/packageman.html

cc: @paul.erickson @apatwary

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
26 26 }
27 27 }
28 28 }
29
29 jar {
  • Author Contributor

    Same closure, but again the chicken-and-egg problem where we can't apply the plugin generated by this project to the project itself.

  • Nicholas Blair Added 1 commit:

    Added 1 commit:

    • 718f28a5 - feat: add artifact-version.groovy expected by Jenkins build
  • Build triggered.

  • Nicholas Blair Added 1 commit:

    Added 1 commit:

    • 161c85a3 - docs: describe how to get Jenkins to tag releases
  • Build triggered.

  • Nicholas Blair Status changed to merged

    Status changed to merged

  • Nicholas Blair mentioned in commit 300638dc

    mentioned in commit 300638dc

  • This is going to be awesome.

  • Please register or sign in to reply
    Loading