Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C continuous-publish-plugin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • adi-iaadi-ia
  • continuous-publish-plugin
  • Merge requests
  • !2

feat: always populate MANIFEST with project.name and .version

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicholas Blair requested to merge npblair/continuous-publish-plugin:release-version into master Aug 31, 2016
  • Overview 15
  • Commits 4
  • Pipelines 0
  • Changes 6

This pull request directs the plugin to configure the jar task (if present, provided by the java plugin) and/or the war task (if present, provided by the war plugin) to set the Implementation-Version and Implementation-Title attributes in the MANIFEST.MF file included in the result.

The end result is that issue #1 (closed) can be satisfied by pulling out Implementation-Version from the MANIFEST. By using MANIFEST, we use a file in Java specifications and we don't have to pollute the build of downstream projects with our own custom properties file.

Manifest reference:

https://docs.oracle.com/javase/tutorial/deployment/jar/packageman.html

cc: @paul.erickson @apatwary

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: release-version