Skip to content
Snippets Groups Projects
Commit 1659587b authored by Isaac Evavold's avatar Isaac Evavold
Browse files

remove uncalled methods and commented-out code

parent 07746b15
No related branches found
No related tags found
No related merge requests found
Pipeline #42662 passed
......@@ -93,8 +93,4 @@ export class AuditViewComponent implements OnInit {
public openNewTab() {
window.open(window.location.href, '_blank', 'noopener noreferrer');
}
public closeAudit() {
this.router.navigateByUrl(`/dars`);
}
}
......@@ -78,7 +78,6 @@ export class DARSViewComponent implements OnInit {
this.dialog
.open<any, any, NewWhatIfAuditFields>(NewWhatIfAuditDialogComponent)
.afterClosed()
// .subscribe(event => console.log(event));
.subscribe(event => {
if (event) {
return this.store.dispatch(
......@@ -92,8 +91,4 @@ export class DARSViewComponent implements OnInit {
}
});
}
public closeAudit() {
this.store.dispatch(new darsActions.CloseAudit());
}
}
......@@ -122,11 +122,6 @@ export class NewWhatIfAuditDialogComponent implements OnInit {
);
const degreePlanFormControl = this.chosenAuditSettings.get('degreePlan');
// if (degreePlanFormControl) {
// degreePlanFormControl.valueChanges.subscribe(plan => {
// this.chosenRoadmapId$.next(plan.roadmapId);
// });
// }
const includeCoursesFrom = this.chosenAuditSettings.get(
'includeCoursesFrom',
......@@ -219,15 +214,6 @@ export class NewWhatIfAuditDialogComponent implements OnInit {
return fallback;
}
}
// Don't think we need this
public roadmapId<T>(fallback: T): number | T {
const control = this.chosenAuditSettings.get('degreePlan');
if (control !== null) {
return control.value.roadmapId;
} else {
return fallback;
}
}
public degreePlannerPlanName<T>(fallback: T): string | T {
const control = this.chosenAuditSettings.get('degreePlan');
......
......@@ -68,7 +68,6 @@ export class DarsApiService {
public getAudit(reportId: number): Observable<Audit> {
const url = `${environment.apiDarsUrl}/auditresults?reportId=${reportId}`;
return this.http.get<any>(url, HTTP_OPTIONS);
// return of(auditResponse);
}
/**
......
......@@ -13,7 +13,6 @@ export enum DarsActionTypes {
ErrorLoadingAudit = '[DARS] Error Loading Audit',
StartLoadingAudit = '[DARS] Start Loading Audit',
DoneLoadingAudit = '[DARS] Done Loading Audit',
CloseAudit = '[DARS] Close Audit',
PopulateDarsState = '[DARS] Done Loading state',
ErrorSendingAudit = 'DARS Error Sending Audit',
......@@ -67,10 +66,6 @@ export class DoneLoadingAudit implements Action {
constructor(public payload: { metadata: AuditMetadata; audit: Audit }) {}
}
export class CloseAudit implements Action {
public readonly type = DarsActionTypes.CloseAudit;
}
export class ErrorSendingAudit implements Action {
public readonly type = DarsActionTypes.ErrorSendingAudit;
constructor(public payload: { message: string }) {}
......
......@@ -8,7 +8,6 @@ type SupportedActions =
| darsActions.PopulateDarsState
| darsActions.StartLoadingAudit
| darsActions.DoneLoadingAudit
| darsActions.CloseAudit
| darsActions.DismissAlert;
export function darsReducer(
......@@ -73,10 +72,6 @@ export function darsReducer(
},
};
}
case DarsActionTypes.CloseAudit: {
// TODO
return state;
}
case DarsActionTypes.DismissAlert: {
return {
...state,
......
......@@ -10,7 +10,6 @@ import { DragDropModule } from '@angular/cdk/drag-drop';
import { RemoveCourseConfirmDialogComponent } from './dialogs/remove-course-confirm-dialog/remove-course-confirm-dialog.component';
import { YearContainerComponent } from '@app/degree-planner/year-container/year-container.component';
import { CourseSearchComponent } from '@app/degree-planner/course-search/course-search.component';
import { AlertContainerComponent } from '../shared/components/alert-container/alert-container.component';
import { EffectsModule } from '@ngrx/effects';
import { DegreePlanEffects } from './store/effects/plan.effects';
import { NoteEffects } from './store/effects/note.effects';
......@@ -41,7 +40,6 @@ import { degreePlannerReducer } from './store/reducer';
NotesDialogComponent,
RemoveCourseConfirmDialogComponent,
YearContainerComponent,
// AlertContainerComponent,
CourseSearchComponent,
],
entryComponents: [NotesDialogComponent, RemoveCourseConfirmDialogComponent],
......
......@@ -16,8 +16,6 @@ export enum UIActionTypes {
OpenSidenav = '[UI] Open Sidenav',
CloseSidenav = '[UI] Close Sidenav',
// DismissAlert = '[UI] Dismiss Disclaimer Alert',
UpdateUserPreferences = '[UI] Update User Preferences',
AddAcademicYear = '[UI} Add Academic Year',
......@@ -66,11 +64,6 @@ export class CloseSidenav implements Action {
public readonly type = UIActionTypes.CloseSidenav;
}
// export class DismissAlert implements Action {
// public readonly type = UIActionTypes.DismissAlert;
// constructor(public payload: { key: string }) {}
// }
export class AddAcademicYear implements Action {
public readonly type = UIActionTypes.AddAcademicYear;
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment