fix for multiple courses requests

src/app/core/service/degree-planner-data.service.ts

@@ -2,7 +2,7 @@ import { Course } from '@app/core/models/course';
 import { Note } from './../models/note';
 import { Injectable } from '@angular/core';
 import { Observable } from 'rxjs';
-import { groupBy, toArray, mergeMap, flatMap, tap, mergeAll, map, distinct } from 'rxjs/operators';
+import { groupBy, toArray, mergeMap, flatMap, tap, mergeAll, map, distinct, share } from 'rxjs/operators';
 
 import { DataService } from '@app/core/data.service';
 
@@ -12,7 +12,7 @@ import { DataService } from '@app/core/data.service';
 export class DegreePlannerDataService {
 	degreePlannerData: Observable<any>;
 	coursesData$: any;
-	termCodes$: any;
+	termCodes: any;
 	planId: number;
 
 	constructor(private dataService: DataService) { }
@@ -23,9 +23,16 @@ export class DegreePlannerDataService {
 
 		this.degreePlannerData = this.dataService.getDegreePlannerCourseData(planId).pipe(
 			map(courses => courses.sort((a, b) => Number(a.termCode) - Number(b.termCode))),
-			mergeAll()
+			mergeAll(),
+			share()
 		);
 
+		this.degreePlannerData.pipe(
+			map(course => course.termCode),
+			distinct(),
+			toArray()
+		).subscribe(termCodes => this.termCodes = termCodes);
+
 		this.coursesData$ = this.degreePlannerData.pipe(
 			groupBy(course => course.termCode),
 			mergeMap(group$ => group$.pipe(toArray())),
@@ -47,12 +54,7 @@ export class DegreePlannerDataService {
 	}
 
 	getAllTerms() {
-		this.termCodes$ = this.degreePlannerData.pipe(
-			map(course => course.termCode),
-			distinct(),
-			toArray()
-		);
-		return this.termCodes$;
+		return this.termCodes;
 	}
 
 	getAllNotes(): Observable<Note[]> {

src/app/degree-planner/degree-planner.component.ts

@@ -39,9 +39,7 @@ export class DegreePlannerComponent {
 		this.selectedDegreePlan = this.degreePlans[0].roadmapId;
 
 		this.coursesData$ = this.degreePlannerDataSvc.getDegreePlanDataById(this.selectedDegreePlan);
-
 		this.degreePlannerDataSvc.getAllNotes().subscribe(notes => { route.snapshot.data.requiredData.notes = notes; });
-		route.snapshot.data.requiredData.termCodes$ = this.degreePlannerDataSvc.getAllTerms();
 
 		// this.coursesData$.subscribe(x => console.log(x));
 		// this.dataService.getDegreePlans()

src/app/degree-planner/shared/course-item/course-item.component.html

@@ -28,7 +28,7 @@
 					<button mat-menu-item [matMenuTriggerFor]="academicYearsGroup">Move</button>
 						<mat-menu #academicYearsGroup="matMenu" class="course-item-submenu">
 							<button mat-menu-item (click)="moveToFavorites(course)" *ngIf="!savedForLater" class="favorites-list">Saved for later</button>
-							<button mat-menu-item *ngFor="let termCode of termCodes$ | async" (click)="savedForLater ? addToTerm(termCode) : switchTerm(termCode)">{{ termCode | getTermDescription }}</button>
+							<button mat-menu-item *ngFor="let termCode of termCodes" (click)="savedForLater ? addToTerm(termCode) : switchTerm(termCode)">{{ termCode | getTermDescription }}</button>
 						</mat-menu>
 					<button mat-menu-item (click)="openRemoveConfirmationDialog(savedForLater)">Remove</button>
 				</mat-menu>

src/app/degree-planner/shared/course-item/course-item.component.ts

@@ -25,7 +25,7 @@ export class CourseItemComponent implements OnInit {
 	degreePlanCourses: any[];
 	selectedDegreePlan: number;
 	// termCodes: any;
-	termCodes$: any;
+	termCodes: any;
 	@Input() course: Course;
 	@Input() courses: Course[];
 	@Input() status: string;
@@ -46,7 +46,7 @@ export class CourseItemComponent implements OnInit {
 			this.degreePlans = route.snapshot.data.requiredData.degreePlans;
 			this.selectedDegreePlan = this.degreePlans[0].roadmapId;
 			this.subjects = route.snapshot.data.requiredData.subjects;
-			this.termCodes$ = route.snapshot.data.requiredData.termCodes$;
+			this.termCodes =  this.degreePlannerDataSvc.getAllTerms();
 		}
 
 	ngOnInit() {