refactor to use termcourses endpoint

src/app/degree-planner/effects/plan.effects.ts

@@ -297,21 +297,16 @@ export class DegreePlanEffects {
   private loadTermsForPlan<T extends { visibleRoadmapId: number }>(stdin: T) {
     return forkJoin(
       this.api.getAllNotes(stdin.visibleRoadmapId),
-      this.api.getAllCourses(stdin.visibleRoadmapId),
+      this.api.getAllTermCourses(stdin.visibleRoadmapId),
       this.api.getActiveTerms(),
     ).pipe(
       // Combine courses and notes by term.
-      map(([notes, courses, currentTerms]) => {
+      map(([notes, termCourses, currentTerms]) => {
         /**
          * Using the notes & courses relevant to the current degree plan and
          * the active terms, generate a sorted list of all unqiue term codes.
          */
-        const uniqueTermCodes = [notes, courses, currentTerms]
-          .map((ts: { termCode: string }[]) => ts.map(t => t.termCode))
-          .reduce((flat, nested) => flat.concat(nested), [])
-          .filter((termCode, index, self) => self.indexOf(termCode) === index)
-          .sort();
-
+        const uniqueTermCodes = termCourses.map(course => course.termCode);
         /**
          * For each unique termCode, build a Term object that includes any
          * courses or notes relevant to that termCode.
@@ -320,7 +315,8 @@ export class DegreePlanEffects {
           return {
             termCode,
             note: notes.find(note => note.termCode === termCode),
-            courses: courses.filter(course => course.termCode === termCode),
+            courses: termCourses.filter(term => term.termCode === termCode)[0]
+              .courses,
           };
         });
 

src/app/degree-planner/services/api.service.ts

@@ -51,9 +51,11 @@ export class DegreePlannerApiService {
     return this.http.get<Note[]>(this.degreePlanEndpoint(roadmapId, 'notes'));
   }
 
-  public getAllCourses(roadmapId: number): Observable<Course[]> {
-    return this.http.get<Course[]>(
-      this.degreePlanEndpoint(roadmapId, 'courses'),
+  public getAllTermCourses(
+    roadmapId: number,
+  ): Observable<{ termCode: string; courses: Course[] }[]> {
+    return this.http.get<{ termCode: string; courses: Course[] }[]>(
+      this.degreePlanEndpoint(roadmapId, 'termcourses'),
     );
   }