Merge branch 'deprecate-attributesmapper' into 'master'

deprecate: LocalUserDetailsAttributesMapper

I'm preparing a 1.7.0 release, thought I'd stick this in there as well.

See merge request !26

uw-spring-security-core/src/main/java/edu/wisc/uwss/local/LocalUserDetailsAttributesMapper.java

@@ -25,9 +25,11 @@ import java.util.List;
  * If you have custom {@link UWUserDetails} that depend on services/daos to complete the model,
  * you may want to consider implementing a {@link LocalUsersAuthenticationAttemptCallback}; that interface
  * participates in the authentication attempt itself, not during application initialization.
- * 
+ *
+ * @deprecated use {@link LocalUserDetailsLoader} instead, to be removed in 2.0
  * @author Nicholas Blair
  */
+@Deprecated
 public interface LocalUserDetailsAttributesMapper {
 
   /**

uw-spring-security-core/src/main/java/edu/wisc/uwss/local/LocalUserDetailsLoader.java

@@ -17,9 +17,15 @@ import edu.wisc.uwss.UWSpringSecurityException;
 /**
  * Interface for loading {@link UWUserDetails} instances from configuration.
  *
- * This interface is an alternative to {@link LocalUserDetailsAttributesMapper}.
+ * This interface is used during application initialization - not during
+ * authentication attempts. Since it is executed during Spring ApplicationContext initialization,
+ * implementations should avoid injecting other service or dao interfaces, as it may be
+ * affected by a race condition.
+ *
+ * If you have custom {@link UWUserDetails} that depend on services/daos to complete the model,
+ * you may want to consider implementing a {@link LocalUsersAuthenticationAttemptCallback}; that interface
+ * participates in the authentication attempt itself, not during application initialization.
  *
- * @see {@link LocalUserDetailsAttributesMapper}
  * @see {@link LocalUserDetailsLoader.Default}
  * @author Nicholas Blair
  */