Don't check types at all (!104) · Merge requests · adi-ia / cbs-techstore-client-php · GitLab

Snippets Groups Projects

Merged Andy Summers requested to merge andrew-summers/cbs-techstore-client-php:no-typechecking into master 6 years ago

This PR removes everything I did in my last PR, and removes PHP 7 type hinting from OrderHeader, OrderPayment, OrderLine and Product. We pretty much don't send the correct type anywhere and let PHP handle conversions, so trying to guard against incorrect types will be really fragile and a lot of overhead.

Please review: @ahoffmann @weizhong-wang @lloyd-carter @KJOYNER

Activity

ADI-IA Jenkins @adi-ia-jenkins · 6 years ago

Maintainer

Build triggered.
ADI-IA Jenkins @adi-ia-jenkins · 6 years ago

Maintainer

Build Started: https://ia-builds.doit.wisc.edu:8443/job/cbs-techstore-client-php-master-pull-requests/129/
ADI-IA Jenkins @adi-ia-jenkins · 6 years ago

Maintainer

Build finished. Tests PASSED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/cbs-techstore-client-php-master-pull-requests/129/
Andy Summers merged 6 years ago

merged
Andy Summers mentioned in commit ff9caab7 6 years ago

mentioned in commit ff9caab7

Please register or sign in to reply