Don't check types at all (!104) · Merge requests · adi-ia / cbs-techstore-client-php

Andy Summers requested to merge andrew-summers/cbs-techstore-client-php:no-typechecking into master Jun 27, 2018

This PR removes everything I did in my last PR, and removes PHP 7 type hinting from OrderHeader, OrderPayment, OrderLine and Product. We pretty much don't send the correct type anywhere and let PHP handle conversions, so trying to guard against incorrect types will be really fragile and a lot of overhead.

Please review: @ahoffmann @weizhong-wang @lloyd-carter @KJOYNER

Don't check types at all

Merge request reports