Add PHPDocs, make PHPUnit a Composer dependency

composer.json

@@ -14,6 +14,7 @@
     "source": "https://git.doit.wisc.edu/adi-ia/uw-php-security"
   },
   "require-dev": {
+    "phpunit/phpunit": "^5.4"
   },
   "autoload": {
     "psr-4": {

src/main/edu/wisc/doit/UserDetailsAttributeMapper.php

@@ -3,7 +3,8 @@
 namespace edu\wisc\doit;
 
 /**
- * 
+ * UserDetailsAttributeMapper defines an interface for mapping common UW user attributes to an associative array. The
+ * constants defined in this interface represent headers sent by UW Federated login that identify a user.
  */
 interface UserDetailsAttributeMapper
 {

src/main/edu/wisc/doit/UserDetailsService.php

@@ -3,7 +3,8 @@
 namespace edu\wisc\doit;
 
 /**
- * 
+ * UserDetailsService is the interface that provides an instance of {@link UserDetails}, typically a {@link UWUserDetails}.
+ * Two concrete implementations are provided, {@link LocalUserDetailsService} and {@link PreauthUserDetailsService}.
  */
 interface UserDetailsService
 {

src/test/edu/wisc/doit/PreauthUserDetailsServiceTest.php

@@ -8,9 +8,17 @@ namespace edu\wisc\doit;
 class PreauthUserDetailsServiceTest extends PreauthTestCase
 {
 
+    /** @var UserDetailsService */
+    private $userService;
+
+    protected function setUp()
+    {
+        parent::setUp();
+        $this->userService = new PreauthUserDetailsService();
+    }
+
     public function testLoadUser() {
-        $userService = new PreauthUserDetailsService();
-        $user = $userService->loadUser();
+        $user = $this->userService->loadUser();
         $this->assertNotNull($user);
         $this->assertEquals("bbadger@wisc.edu", $user->getEppn());
         $this->assertEquals("UW123A456", $user->getPvi());
@@ -22,4 +30,11 @@ class PreauthUserDetailsServiceTest extends PreauthTestCase
         $this->assertEquals("BADGER", $user->getLastName());
     }
 
+    public function testLoadUserWithNoEPPN() {
+        // Clear EPPN to simulate no EPPN
+        $_SERVER[UserDetailsAttributeMapper::EPPN] = null;
+        $user = $this->userService->loadUser();
+        $this->assertNull($user);
+    }
+
 }