Test all the things!

This merge request improves the code coverage of the project's unit tests.

I broke up this rather large set of changes into separate commits. See the individual commit messages for details.

• 75773b6d - Use PHPUnit provided by Composer instead of downloading a PHAR
• 737771f2 - Convert dashes to underscores when converting to HTTP headers
• 08aaa966 - Group conditional logic for clarity
• 1477621c - Create missing tests for PreauthUserDetailsProvider, introduce an EnvironmentHelper
• b74fd618 - Federated preauth tests made consistent with new preauth tests, improved coverage, moved test data from JSON to source code
• 09d36d36 - LocalUserDetailsProvider throws Exception if JSON is invalid, returns null if JSON is missing
• d021fd72 - Verify missing attributes are set as false
• e29430a9 - Docblock and PSR-2 formatting improvements

PHP Trait

In 1477621c, I introduced a lesser-known feature of PHP called a trait. It allows one to "inject" common methods into any class without requiring inheritance.

@andrew-summers @weizhong-wang @KJOYNER

Build Started: https://ia-builds.doit.wisc.edu:8443/job/uw-php-security-master-pull-requests/21/

Build triggered.

Build finished. Tests FAILED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/uw-php-security-master-pull-requests/21/

build me

Build triggered.

Build Started: https://ia-builds.doit.wisc.edu:8443/job/uw-php-security-master-pull-requests/22/

Build finished. Tests FAILED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/uw-php-security-master-pull-requests/22/

build me

Build triggered.

Build Started: https://ia-builds.doit.wisc.edu:8443/job/uw-php-security-master-pull-requests/23/

Build finished. Tests FAILED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/uw-php-security-master-pull-requests/23/

Added 1 commit:

• c4f74ce2 - Call the actual PHP script instead of a shell script

Build triggered.

Build Started: https://ia-builds.doit.wisc.edu:8443/job/uw-php-security-master-pull-requests/24/

Build finished. Tests PASSED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/uw-php-security-master-pull-requests/24/

The Jenkins issue was because Composer brings down a different PHPUnit executable when run on Windows. I had to switch what PHPUnit script is pointed to

The trait stuff is cool, nice!

Build triggered.