Consume isMemberOf attribute as single value with semi-colon delimited list of manifest groups

In the List Library application, which is attempting to consume Manifest groups as UW Spring Security authorities, we discovered that multiple Manifest groups are not provided by the login server as multiple isMemberOf headers but as one string with the Manifest groups delimited by semi-colons.

This PR revises the default Preauth mapper to split the isMemberOf string apart into a Java collection, which is the correct format for the authorities argument to the UWUserDetailsImpl constructor.

Notify: @paul.erickson @ahoffmann @gutkowski @bkeen

uw-spring-security-core/src/main/java/edu/wisc/uwss/preauth/PreauthenticatedUserDetailsAttributeMapper.java

@@ -85,7 +85,18 @@ public interface PreauthenticatedUserDetailsAttributeMapper {
       String emplid = request.getHeader(isisEmplidHeader);
       Collection<String> uddsMembership = safeGetHeaders(request, uddsHeader);
       String email = request.getHeader(emailAddressHeader);
-      Collection<String> manifestGroups = safeGetHeaders(request, manifestHeader);
+
+      Collection<String> manifestGroups = new ArrayList<>();
+      String manifestValue = request.getHeader(manifestHeader);
+      if (manifestValue != null) {
+        String[] manifestGroupStrings = manifestValue.split(";");
+        for (String manifestGroupString : manifestGroupStrings) {
+          if (!manifestGroupString.trim().isEmpty()) {
+            manifestGroups.add(manifestGroupString.trim());
+          }
+        }
+      }
+
       UWUserDetailsImpl result = UWUserDetailsImpl.newInstance(pvi, uid, "", cn, email, uddsMembership, manifestGroups);
       result.setSource("edu.wisc.uwss.preauth");
       result.setEppn(eppn);

[Andrew Hoffmann]

This multi-line for-loop could technically use a single-lined Java 8 stream! Since we're talking about a handful of elements here, it's not strictly necessary. However, I highly recommend taking it on as a personal coding challenge.

[Tim Levett]

Target is currently set to java7, but I totally agree. #insert-crossing-the-streams-reference

MyUW should be going to Java 8 very very soon.