Skip to content
Snippets Groups Projects

Change return types for 4 spring UserDetails booleans to true

Merged Change return types for 4 spring UserDetails booleans to true
npblair/uw-spring-security:unlock-udsperson into master
Merged Nicholas Blair requested to merge npblair/uw-spring-security:unlock-udsperson into master

These 4 fields influence behavior of a lot of Spring Security components. When they were previously set to false, these users could not log in or pass any authorization checks.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
uw-spring-security-core/src/test/java/edu/wisc/uwss/uds/UdsPersonUserDetailsImplTest.java
48 48 assertEquals(UdsPersonUserDetailsImpl.USER_DETAILS_SOURCE, userDetails.getSource());
49 49 assertEquals(Collections.emptyList(), userDetails.getUddsMembership());
50 50 assertNull(userDetails.getUsername());
51 assertFalse(userDetails.isAccountNonExpired());
  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build triggered.

  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build Started: https://ia-builds.doit.wisc.edu:8443/job/uw-spring-security-master-pull-requests/55/

  • ADI-IA Jenkins
    ADI-IA Jenkins @adi-ia-jenkins ·
    Maintainer

    Build finished. Tests PASSED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/uw-spring-security-master-pull-requests/55/

  • Andy Summers
    Andy Summers @andrew-summers ·

    Great!

  • Nicholas Blair Status changed to merged

    Status changed to merged

  • Nicholas Blair mentioned in commit 1629ad86

    mentioned in commit 1629ad86

    • Please register or sign in to reply