Add PviAttributeBindingFilter

AttributeBindingFilter is a filter that is used along with rest-proxy to add headers to a request based on the attributes added with the filter.

WIP for suggestions/critiques on the design and implementation.

Please review: @paul.erickson @ahoffmann @bjsousa

Build triggered.

Build Started: https://ia-builds.doit.wisc.edu:8443/job/uw-spring-security-master-pull-requests/57/

Build finished. Tests PASSED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/uw-spring-security-master-pull-requests/57/

I am confused by this contribution though - I'm expecting to see the magic SecurityContextHolder.getContext().getAuthentication().getPrincipal(), a cast to UWUserDetails, and invocation of a specific method, like UWUserDetails.getPvi().

We already have something to manually wire in configured attributes:

https://git.doit.wisc.edu/adi-ia/adi-development/tree/master/preauth-simulation-filter/src/main/java/com/github/nblair/web

Ah! I was confused about the use case for this then. I thought that that ^ was what we were adding. So this will be used specifically for adding user attributes?

This, essentialy verbatim, is what we want in uw-spring-security-web:

https://git.doit.wisc.edu/adi-ia/star/blob/master/star-app/src/main/java/edu/wisc/doit/financials/star/app/RequestOnBehalfOfFilter.java

That's the re-usable bit.

Added 1 commit:

• b3bdc2f8 - Change to AttributeBindingFilter for user specific attributes

Is the more along the lines of what you were thinking? It doesn't have to be specific to PVI, though that's the only thing implemented right now (for illustration purposes).

Build triggered.

Build Started: https://ia-builds.doit.wisc.edu:8443/job/uw-spring-security-master-pull-requests/58/

Build finished. Tests PASSED. Build results available at: https://ia-builds.doit.wisc.edu:8443/job/uw-spring-security-master-pull-requests/58/

Title changed from [WIP] Add RestProxyAttributeBindingFilter to [WIP] Add AttributeBindingFilter

General question: Can't we just add the 'On-Behalf-Of' header at this point, or would rest-proxy fail to proxy it along on the outgoing request?

Added 1 commit:

• 8efef949 - Change to PviAttributeBindingFilter

Build triggered.