- May 31, 2016
-
-
Andy Summers authored
Allow `null` in Product::setCost() PHP type hinting prevents anything other than the hinted type from being passed to a function. This includes `null`, and we don't want to require a product cost always be added when adding a product in Magento. Adding the default `= null` to the parameter allows `null` to be passed to the function. Please review: @ahoffmann @weizhong-wang @lloyd-carter See merge request !22
-
- May 23, 2016
-
-
Andy Summers authored
PHP type hinting prevents anything other than the hinted type from being passed to a function. This includes `null`, and we don't want to require a product cost always be added when adding a product in Magento. Adding the default `= null` to the parameter allows `null` to be passed to the function.
-
- May 18, 2016
-
-
Andy Summers authored
Add initial ProductPriceService interface and mock implementation `ProductPriceService` is a service for changing product prices in CBS. This is an initial mock implementation which will be fleshed out as new constraints are found. Please review: @ahoffmann @weizhong-wang @lloyd-carter See merge request !21
-
- May 11, 2016
-
-
Andy Summers authored
-
- Apr 29, 2016
-
-
Paul Erickson authored
Expose pricing template and rename "item number" to the more common "sku" @ahoffmann @weizhong-wang @SDUNAGAN @lloyd-carter See merge request !20
-
Paul Erickson authored
-
- Apr 28, 2016
-
-
Paul Erickson authored
Update client from latest WSDL and update documentation This includes two API changes: 1. Add updateProduct service method (backwards-compatible) 2. Return response object instead of boolean (backwards-incompatible, thus the major version bump) @ahoffmann @weizhong-wang @lloyd-carter @SDUNAGAN See merge request !19
-
Paul Erickson authored
-
- Apr 26, 2016
-
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
ProductService returns a response object instead of boolean I created a simple ProductServiceResponse class that provides a success flag and an associated message. This will help provide validation feedback to the end user in Magento when CBS doesn't like their input. I've only implemented this change for the Mock instance, since we don't have a new WSDL yet. @paul.erickson @lloyd-carter @weizhong-wang @SDUNAGAN See merge request !17
-
Andrew Hoffmann authored
MockProductServiceClient#__constructor now takes in a ProductServiceResponse parameter instead of a boolean flag.
-
- Apr 25, 2016
-
-
Andrew Hoffmann authored
Created a ProductServiceResponse class to encapsulate a repsonse status when calling a method in ProductService. Updated the mock implementation to reflect it.
-
- Apr 22, 2016
-
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
UnsupportedCurrencyException Forgot to include in !14. Will merge when tests pass. See merge request !16
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
Unit Tests for MockProductServiceClient Because I feel that a part of me is incomplete without the class being covered. Plus, these will likely be more important when we have more interesting responses to send back other than true or false. SO YOU'RE WELCOME. @paul.erickson @weizhong-wang @lloyd-carter @SDUNAGAN See merge request !15
-
Andrew Hoffmann authored
Add additional Product attributes for POS This PR adds additional fields to the `Product` class in order to support point-of-sale. I also introduce other types than `string` in the class. The most notable is the use of the [Money\Money library](https://github.com/moneyphp/money) for safe handling of currency. Integration test fails for these changes, which I have a note out to @lloyd-carter about. @paul.erickson @weizhong-wang @SDUNAGAN @lloyd-carter See merge request !14
-
Andrew Hoffmann authored
Moved the converstion from Money to float logic into a private method. Removed the check for an integer from Money#getAmount, since I trust the library to honor its contract (and returning floats would defeat the purpose of it.) Added verification that we are working in USD.
-
- Apr 21, 2016
-
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
Updated README to include references to CBS and the techstore project No further information. @paul.erickson @weizhong-wang @lloyd-carter See merge request !12
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
Adding unit tests for MockProductServiceClient because it drives me nuts not seeing a class covered and I've had too much mountain dew today
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
Added additional fields in the Product class to support Point-of-Sale. Enforced stricter types rather than everything being a string, especially with Product#cost, which uses the Money library for PHP. Removed Product#description because the endpoint does not support a long description of the product.
-
Andrew Hoffmann authored
Refactor Product constructor Refactored `Product` constructor to remove all parameters. Instead, the client should use the setters to set object properties. Updated the setters to return the object instance for convenience. Updated README to reflect this change. I am making this change as the `Product` object is going to become more complex and code quality analysis is already complaining about 4 parameters in the constructor being too many. Paging Doctors @paul.erickson @weizhong-wang @lloyd-carter @SDUNAGAN See merge request !13
-
Andrew Hoffmann authored
Refactored Product constructor to remove all parameters. Instead, the client should use the setters to set object properties. Updated the setters to return the object instance for convenience. Updated README to reflect this change. I am making this change as the Product object is going to become more complex and code quality analysis is already complaining about 4 parameters in the constructor being too high.
-
Andrew Hoffmann authored
-
- Apr 13, 2016
-
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
-
Andrew Hoffmann authored
Cleaned up README and provided accurate usage examples The README was a little cluttered with unnecessary information and inaccurate usage examples. Fast-tracking merge so I can cut a release. @alundholm @weizhong-wang @paul.erickson @lloyd-carter @SDUNAGAN See merge request !11
-