Skip to content
Snippets Groups Projects

SSN Decryption Tutorials

Merged Rebecca Wheeler requested to merge SSH_POC into master
Edited by Rebecca Wheeler

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jared Kosanovic
  • Jared Kosanovic
  • Nice work on this tutorial. I have some minor feedback but it's looking good overall.

  • Jared Kosanovic requested changes

    requested changes

  • Also sharing some git feedback here in case it's helpful for the whole team. I'd suggest checking the "squash commits" checkbox and editing the squash commit message to something summarizing the entire change (e.g. "Added tutorial for using Person API SSNs in IICS"). This makes the git history clear and helps remove the noise of all the WIP commits that were added to the merge request.

    I'd also suggest adding a link to the GitLab issue in the merge request description. Gitlab will then crosslink the merge request in the issue. It's helpful to have a record of merge request and issue relationships.

  • added 1 commit

    • f567c800 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Rebecca Wheeler resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading