Force a new deployment of the autoscaling group when changes are made to the launch config

• Force a new deployment of the autoscaling group when changes are made to the launch config

This config will ensure that a new instance is deployed using the new launch config, and the old instance will be terminated after the new instance is running successfully. Based on solution found by Jared here: https://groups.google.com/g/terraform-tool/c/7Gdhv1OAc80/m/iNQ93riiLwAJ?pli=1

@interop/ipt

terraform/autoscaling-group.tf

-resource "aws_autoscaling_group" "secure-agent-autoscaling-group" {
-  # as per our current licesning in IICS, each docker instance that
-  # runs on EC2 will treat at as a new license.
-  name             = "secure-agent-autoscaling-group"
-  desired_capacity = 1
-  max_size         = 1
-  min_size         = 1
-
-  # make sure deployed EC2 instance is in the same AZ as the EFS
-  # see https://docs.aws.amazon.com/efs/latest/ug/mounting-fs-mount-cmd-dns-name.html
-  vpc_zone_identifier  = [sort(data.aws_subnet_ids.subnets.ids)[0]]
-  health_check_type    = "EC2"
-  launch_configuration = aws_launch_configuration.secure-agent-launch-config.name
-  tag {
-    key                 = "Name"
-    value               = "IICS Secure Agent"
-    propagate_at_launch = true
-  }
-}
-
 data "aws_ssm_parameter" "ecs-optimized" {
   name = "/aws/service/ecs/optimized-ami/amazon-linux-2/recommended/image_id"
 }
 
 resource "aws_launch_configuration" "secure-agent-launch-config" {
-  name              = "secure-agnet-launch-configuration"
-
   # Fix me: Make this use the ecs-optimized parameter so that it always uses the latest version.
   image_id          = "ami-00f69adbdc780866c"
 
@@ -44,3 +22,27 @@ resource "aws_launch_configuration" "secure-agent-launch-config" {
     create_before_destroy = true
   }
 }
+
+resource "aws_autoscaling_group" "secure-agent-autoscaling-group" {
+  # as per our current licesning in IICS, each docker instance that
+  # runs on EC2 will treat at as a new license.
+  name             = "secure-agent-autoscaling-group-${aws_launch_configuration.secure-agent-launch-config.name}"
+  desired_capacity = 1
+  max_size         = 1
+  min_size         = 1
+  min_elb_capacity = 1
+
+  # make sure deployed EC2 instance is in the same AZ as the EFS
+  # see https://docs.aws.amazon.com/efs/latest/ug/mounting-fs-mount-cmd-dns-name.html
+  vpc_zone_identifier  = [sort(data.aws_subnet_ids.subnets.ids)[0]]
+  health_check_type    = "EC2"
+  launch_configuration = aws_launch_configuration.secure-agent-launch-config.name
+  tag {
+    key                 = "Name"
+    value               = "IICS Secure Agent"
+    propagate_at_launch = true
+  }
+  lifecycle { 
+    create_before_destroy = true
+  }
+}