Update file efs.tf
1 unresolved thread
1 unresolved thread
Added backups to EFS terraform build
Merge request reports
Activity
Filter activity
requested review from @SAM.CARPENTER and @JARED.BALKMAN
assigned to @REBECCA.WHEELER
Just have a couple suggestions/questions
- I'd suggest a more descriptive merge request title, as well as including the jira ticket you're working on in the title or description. You can just use the jira issue key (instead of the whole URL) and Gitlab will automatically hyperlink it.
- How long will backups be kept for? Is there a default value?
- If you haven't already, I'd suggest running this terraform in the dev environment before merging the merge request, just in case you need to make additional changes.
- I will definitely add more descriptive merge title in the future with inclusion of story link
- Backups have a default retention of 35 days and I have verified in AWS within the backup vault
- It passed the build pipeline, so I thought it was alright. I will tag on the dev environment test in the story I created for adjustments to the ci https://jira.doit.wisc.edu/jira/browse/EIINT-494
mentioned in commit ad52c5e7
Please register or sign in to reply