Skip to content
Snippets Groups Projects
Commit d021fd72 authored by Andrew Hoffmann's avatar Andrew Hoffmann
Browse files

Verify missing attributes are set as false 

Switch to static calls of PHPUnit assertion methods
parent 09d36d36
No related branches found
No related tags found
1 merge request!12Test all the things!
Hide whitespace changes
Inline Side-by-side
src/test/edu/wisc/doit/uwphps/preauth/PreauthUserDetailsProviderTest.php
+ 28
− 17
View file @ d021fd72
...@@ -54,17 +54,17 @@ class PreauthUserDetailsProviderTest extends \PHPUnit_Framework_TestCase ...@@ -54,17 +54,17 @@ class PreauthUserDetailsProviderTest extends \PHPUnit_Framework_TestCase
public function loadsUser() public function loadsUser()
{ {
$this->setEnvironment($this->environment); $this->setEnvironment($this->environment);
$user = $this->provider->loadUser(); $user = $this->provider->loadUser();
$this->assertEquals($this->environment[PreauthUserDetailsProvider::EPPN], $user->getEppn()); static::assertNotNull($user);
$this->assertEquals($this->environment[PreauthUserDetailsProvider::PVI], $user->getPvi()); static::assertEquals($this->environment[PreauthUserDetailsProvider::EPPN], $user->getEppn());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::FULL_NAME], $user->getFullName()); static::assertEquals($this->environment[PreauthUserDetailsProvider::PVI], $user->getPvi());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::EMAIL], $user->getEmailAddress()); static::assertEquals($this->environment[PreauthUserDetailsProvider::FULL_NAME], $user->getFullName());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::SOURCE], $user->getSource()); static::assertEquals($this->environment[PreauthUserDetailsProvider::EMAIL], $user->getEmailAddress());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::ISIS_EMPLID], $user->getIsisEmplid()); static::assertEquals($this->environment[PreauthUserDetailsProvider::SOURCE], $user->getSource());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::FIRST_NAME], $user->getFirstName()); static::assertEquals($this->environment[PreauthUserDetailsProvider::ISIS_EMPLID], $user->getIsisEmplid());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::LAST_NAME], $user->getLastName()); static::assertEquals($this->environment[PreauthUserDetailsProvider::FIRST_NAME], $user->getFirstName());
static::assertEquals($this->environment[PreauthUserDetailsProvider::LAST_NAME], $user->getLastName());
} }
/** @test */ /** @test */
...@@ -73,13 +73,24 @@ class PreauthUserDetailsProviderTest extends \PHPUnit_Framework_TestCase ...@@ -73,13 +73,24 @@ class PreauthUserDetailsProviderTest extends \PHPUnit_Framework_TestCase
$this->setEnvironment($this->toHttpHeaders($this->environment)); $this->setEnvironment($this->toHttpHeaders($this->environment));
$user = $this->providerWithHttp->loadUser(); $user = $this->providerWithHttp->loadUser();
$this->assertEquals($this->environment[PreauthUserDetailsProvider::EPPN], $user->getEppn()); static::assertNotNull($user);
$this->assertEquals($this->environment[PreauthUserDetailsProvider::PVI], $user->getPvi()); static::assertEquals($this->environment[PreauthUserDetailsProvider::EPPN], $user->getEppn());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::FULL_NAME], $user->getFullName()); static::assertEquals($this->environment[PreauthUserDetailsProvider::PVI], $user->getPvi());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::EMAIL], $user->getEmailAddress()); static::assertEquals($this->environment[PreauthUserDetailsProvider::FULL_NAME], $user->getFullName());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::SOURCE], $user->getSource()); static::assertEquals($this->environment[PreauthUserDetailsProvider::EMAIL], $user->getEmailAddress());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::ISIS_EMPLID], $user->getIsisEmplid()); static::assertEquals($this->environment[PreauthUserDetailsProvider::SOURCE], $user->getSource());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::FIRST_NAME], $user->getFirstName()); static::assertEquals($this->environment[PreauthUserDetailsProvider::ISIS_EMPLID], $user->getIsisEmplid());
$this->assertEquals($this->environment[PreauthUserDetailsProvider::LAST_NAME], $user->getLastName()); static::assertEquals($this->environment[PreauthUserDetailsProvider::FIRST_NAME], $user->getFirstName());
static::assertEquals($this->environment[PreauthUserDetailsProvider::LAST_NAME], $user->getLastName());
}
/** @test */
public function missingAttributeIsFalse()
{
$this->setEnvironment($this->environment);
$this->removeEnvironmentVariable(PreauthUserDetailsProvider::ISIS_EMPLID);
$user = $this->provider->loadUser();
static::assertNotNull($user);
static::assertFalse($user->getIsisEmplid());
} }
} }
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment