Test all the things!

This merge request improves the code coverage of the project's unit tests.

I broke up this rather large set of changes into separate commits. See the individual commit messages for details.

• 75773b6d - Use PHPUnit provided by Composer instead of downloading a PHAR
• 737771f2 - Convert dashes to underscores when converting to HTTP headers
• 08aaa966 - Group conditional logic for clarity
• 1477621c - Create missing tests for PreauthUserDetailsProvider, introduce an EnvironmentHelper
• b74fd618 - Federated preauth tests made consistent with new preauth tests, improved coverage, moved test data from JSON to source code
• 09d36d36 - LocalUserDetailsProvider throws Exception if JSON is invalid, returns null if JSON is missing
• d021fd72 - Verify missing attributes are set as false
• e29430a9 - Docblock and PSR-2 formatting improvements

PHP Trait

In 1477621c, I introduced a lesser-known feature of PHP called a trait. It allows one to "inject" common methods into any class without requiring inheritance.

@andrew-summers @weizhong-wang @KJOYNER

src/test/edu/wisc/doit/uwphps/preauth/PreauthUserDetailsProviderTest.php

@@ -54,17 +54,17 @@ class PreauthUserDetailsProviderTest extends \PHPUnit_Framework_TestCase
     public function loadsUser()
     {
         $this->setEnvironment($this->environment);
-
         $user = $this->provider->loadUser();
 
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::EPPN], $user->getEppn());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::PVI], $user->getPvi());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::FULL_NAME], $user->getFullName());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::EMAIL], $user->getEmailAddress());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::SOURCE], $user->getSource());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::ISIS_EMPLID], $user->getIsisEmplid());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::FIRST_NAME], $user->getFirstName());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::LAST_NAME], $user->getLastName());
+        static::assertNotNull($user);
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::EPPN], $user->getEppn());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::PVI], $user->getPvi());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::FULL_NAME], $user->getFullName());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::EMAIL], $user->getEmailAddress());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::SOURCE], $user->getSource());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::ISIS_EMPLID], $user->getIsisEmplid());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::FIRST_NAME], $user->getFirstName());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::LAST_NAME], $user->getLastName());
     }
 
     /** @test */
@@ -73,13 +73,24 @@ class PreauthUserDetailsProviderTest extends \PHPUnit_Framework_TestCase
         $this->setEnvironment($this->toHttpHeaders($this->environment));
         $user = $this->providerWithHttp->loadUser();
 
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::EPPN], $user->getEppn());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::PVI], $user->getPvi());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::FULL_NAME], $user->getFullName());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::EMAIL], $user->getEmailAddress());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::SOURCE], $user->getSource());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::ISIS_EMPLID], $user->getIsisEmplid());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::FIRST_NAME], $user->getFirstName());
-        $this->assertEquals($this->environment[PreauthUserDetailsProvider::LAST_NAME], $user->getLastName());
+        static::assertNotNull($user);
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::EPPN], $user->getEppn());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::PVI], $user->getPvi());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::FULL_NAME], $user->getFullName());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::EMAIL], $user->getEmailAddress());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::SOURCE], $user->getSource());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::ISIS_EMPLID], $user->getIsisEmplid());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::FIRST_NAME], $user->getFirstName());
+        static::assertEquals($this->environment[PreauthUserDetailsProvider::LAST_NAME], $user->getLastName());
+    }
+
+    /** @test */
+    public function missingAttributeIsFalse()
+    {
+        $this->setEnvironment($this->environment);
+        $this->removeEnvironmentVariable(PreauthUserDetailsProvider::ISIS_EMPLID);
+        $user = $this->provider->loadUser();
+        static::assertNotNull($user);
+        static::assertFalse($user->getIsisEmplid());
     }
 }